Review Request 125540: Use more descriptive names and comments for VPN plugins

Jan Grulich jgrulich at redhat.com
Tue Oct 6 16:08:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125540/
-----------------------------------------------------------

(Updated Oct. 6, 2015, 4:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for Localization and Translation (l10n), Network Management and Lamarque Souza.


Changes
-------

Submitted with commit 41a1e711d0299f261b9c770e6788d76a4aaeba28 by Jan Grulich to branch master.


Repository: plasma-nm


Description
-------

Currently we have for each VPN plugin just its simple name and as a comment we have just "xxxx plugin" which is kinda useless so I took more descriptive names and comments from NetworkManager. Better comments can be used in future also for tooltips, but so far from what I tried it doesn't seem to work for QActions.


Diffs
-----

  vpn/l2tp/plasmanetworkmanagement_l2tpui.desktop fd5ee6f 
  vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop e5440df 
  vpn/openswan/plasmanetworkmanagement_openswanui.desktop 64e73cc 
  vpn/openvpn/plasmanetworkmanagement_openvpnui.desktop 36a3ef9 
  vpn/pptp/plasmanetworkmanagement_pptpui.desktop e02d46c 
  vpn/ssh/plasmanetworkmanagement_sshui.desktop f775a46 
  vpn/sstp/plasmanetworkmanagement_sstpui.desktop 267d166 
  vpn/strongswan/plasmanetworkmanagement_strongswanui.desktop a327c23 
  vpn/vpnc/plasmanetworkmanagement_vpncui.desktop 41f4e77 

Diff: https://git.reviewboard.kde.org/r/125540/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20151006/94a80fd3/attachment-0001.html>


More information about the kde-networkmanager mailing list