Review Request 126049: [plasma-nm] optimize string operations
Nick Shaforostoff
shafff at ukr.net
Sat Nov 14 01:13:05 UTC 2015
> On Nov. 13, 2015, 10:09 p.m., Lamarque Souza wrote:
> > kded/secretagent.cpp, line 167
> > <https://git.reviewboard.kde.org/r/126049/diff/1/?file=416683#file416683line167>
> >
> > Any reason for not using QStringLiteral with contains() method?
as qstring has overload for qlatin1string it is the same as for indexOf() here:
http://catchchallenger.first-world.info//wiki/Benchmark_for_conception#String
i.e. qlatin1string is even faster than qstringliteral
- Nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126049/#review88336
-----------------------------------------------------------
On Nov. 13, 2015, 9:50 p.m., Nick Shaforostoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126049/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 9:50 p.m.)
>
>
> Review request for Network Management, Jan Grulich and Lamarque Souza.
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> apart from qstringliteral/qlatin1string/qstringref related optimization,
> i have changed context menu code from exec() to popup() and made it delete itself once the menu is closed
>
> also note the simplicity of using chop() instead of remove()
>
>
> Diffs
> -----
>
> editor/connectioneditor.cpp 0eaeafe
> editor/main.cpp a5ec1e2
> kded/notification.cpp 508443e
> kded/passworddialog.cpp 56db793
> kded/pindialog.cpp 83553f0
> kded/secretagent.cpp 5fc3ee4
> kded/service.cpp 8b4048d
> libs/editor/simpleipv4addressvalidator.cpp 1e7f240
> libs/editor/simpleipv6addressvalidator.cpp 5b87d69
> libs/editor/vpnuiplugin.cpp 1dd7b53
> libs/models/networkmodelitem.cpp 5182f04
> libs/uiutils.cpp 7ad2903
> vpn/openconnect/openconnectauth.cpp a987031
>
> Diff: https://git.reviewboard.kde.org/r/126049/diff/
>
>
> Testing
> -------
>
> compiled and launched, opened connection context menu
>
>
> Thanks,
>
> Nick Shaforostoff
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20151114/162c8174/attachment.html>
More information about the kde-networkmanager
mailing list