Review Request 126049: [plasma-nm] optimize string operations
Jan Grulich
jgrulich at redhat.com
Fri Nov 13 07:13:03 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126049/#review88311
-----------------------------------------------------------
Looks good to me, I would wait for Lamarque opinion to be sure there is no potential problem.
- Jan Grulich
On Lis. 12, 2015, 11:39 odp., Nick Shaforostoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126049/
> -----------------------------------------------------------
>
> (Updated Lis. 12, 2015, 11:39 odp.)
>
>
> Review request for Network Management and Jan Grulich.
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> apart from qstringliteral/qlatin1string/qstringref related optimization,
> i have changed context menu code from exec() to popup() and made it delete itself once the menu is closed
>
> also note the simplicity of using chop() instead of remove()
>
>
> Diffs
> -----
>
> editor/connectioneditor.cpp 0eaeafe
> editor/main.cpp a5ec1e2
> kded/notification.cpp 508443e
> kded/passworddialog.cpp 56db793
> kded/pindialog.cpp 83553f0
> kded/secretagent.cpp 5fc3ee4
> kded/service.cpp 8b4048d
> libs/editor/simpleipv4addressvalidator.cpp 1e7f240
> libs/editor/simpleipv6addressvalidator.cpp 5b87d69
> libs/editor/vpnuiplugin.cpp 1dd7b53
> libs/models/networkmodelitem.cpp 5182f04
> libs/uiutils.cpp 7ad2903
> vpn/openconnect/openconnectauth.cpp a987031
>
> Diff: https://git.reviewboard.kde.org/r/126049/diff/
>
>
> Testing
> -------
>
> compiled and launched, opened connection context menu
>
>
> Thanks,
>
> Nick Shaforostoff
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20151113/ba3dd1be/attachment.html>
More information about the kde-networkmanager
mailing list