Review Request 126029: Re-check connection state and other properties to be sure they are actual
Lamarque Souza
lamarque at kde.org
Wed Nov 11 14:01:42 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126029/#review88254
-----------------------------------------------------------
Ship it!
Ship It!
- Lamarque Souza
On Nov. 11, 2015, 1:25 p.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126029/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 1:25 p.m.)
>
>
> Review request for Network Management and Lamarque Souza.
>
>
> Bugs: 352326
> http://bugs.kde.org/show_bug.cgi?id=352326
>
>
> Repository: networkmanager-qt
>
>
> Description
> -------
>
> In case when an active connection gets activated too early, before we are connected to PropertiesChanged signal, we won't be notified about changed state. This patch just re-checks some related properties after we connect to PropertiesChanged signal and additionally notifies about changes so we don't miss them.
>
>
> Diffs
> -----
>
> src/activeconnection.cpp 4426327
>
> Diff: https://git.reviewboard.kde.org/r/126029/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20151111/47c77c04/attachment.html>
More information about the kde-networkmanager
mailing list