Review Request 121467: Added support for SSTP VPN in plasma-nm (GCI task)

[Jan Grulich]

> On Bře. 15, 2015, 7:05 odp., Lamarque Souza wrote:
> > Any idea why this patch has not been updated in months?
> 
> Lamarque Souza wrote:
>     By the way, bug 338521 should be added to this bug's information.
> 
> Jan Grulich wrote:
>     Because the student gave it up, he used code of someone else from github and then tried to port it to KF5, but unfortunately he failed (mean that he even didn't manage to compile it). I don't think that he will update this review.
> 
> Lamarque Souza wrote:
>     So we can drop this review request, right?

Yes, but I think that only the submitter can discard it or someone with admin rights.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121467/#review77535
-----------------------------------------------------------


On Pro. 12, 2014, 4:23 odp., William Boren wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121467/
> -----------------------------------------------------------
> 
> (Updated Pro. 12, 2014, 4:23 odp.)
> 
> 
> Review request for Network Management and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Added support for SSTP VPN in plasma-nm (GCI task)
> 
> 
> Diffs
> -----
> 
>   plasma-nm-2/vpn/sstp/CMakeLists.txt PRE-CREATION 
>   plasma-nm-2/vpn/sstp/Messages.sh PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstp.h PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstp.cpp PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpadvanced.ui PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpauth.h PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpauth.cpp PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpauth.ui PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpprop.ui PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpwidget.h PRE-CREATION 
>   plasma-nm-2/vpn/sstp/sstpwidget.cpp PRE-CREATION 
>   plasma-nm-2/vpn/sstp/nm-sstp-service.h PRE-CREATION 
>   plasma-nm-2/vpn/sstp/plasmanetworkmanagement_sstpui.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> William Boren
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150316/5c7ea17c/attachment.html>