Review Request 122860: Set LEAP password mode on by default in ui.

[Lamarque Souza]

> On March 8, 2015, 8:58 p.m., Lamarque Souza wrote:
> > libs/editor/settings/ui/802-1x.ui, line 234
> > <https://git.reviewboard.kde.org/r/122860/diff/1/?file=353807#file353807line234>
> >
> >     This change makes sense but I cannot reproduce this problem here. Somehow Plasma NM from master branch correctly set this line edit's password mode without this change.
> 
> Rajeesh K Nambiar wrote:
>     Ah, indeed - this doesn't manifest in "Security: LEAP", but in "Security: WPA & WPA2 Enterprise > Authentication: LEAP", this patch fixes the latter one. Former setting is in libs/editor/settings/ui/wifisecurity.ui, where the passwordMode is already set.

Ah, now I can reproduce it.


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122860/#review77192
-----------------------------------------------------------


On March 8, 2015, 9:17 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122860/
> -----------------------------------------------------------
> 
> (Updated March 8, 2015, 9:17 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> WPA/WPA2 Enterprise 802-1x security setting editor displays LEAP authentication setting password text by default. Set the passoword mode on to mask the text.
> 
> 
> Diffs
> -----
> 
>   libs/editor/settings/ui/802-1x.ui 1881b41 
> 
> Diff: https://git.reviewboard.kde.org/r/122860/diff/
> 
> 
> Testing
> -------
> 
> Couldn't test build (as I have kf5-networkmanager-qt 5.7.0 installed which is missing commit bbaa598b82213022af459e61f4e55d9dc116cfc2 to include NM headers).
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150308/7a8b45e2/attachment.html>