Review Request 122835: Make applet's tooltip visually more consistent with other applets

Lamarque Souza lamarque at kde.org
Thu Mar 5 23:39:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122835/#review77077
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza


On March 5, 2015, 11:22 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122835/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 11:22 p.m.)
> 
> 
> Review request for Network Management, Plasma and Solid.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Make applet's tooltip visually more consistent with other applets
> 
> Tooltips with linebreaks and bold text are uncommon in other applets.
> This patch makes the NM applet's tooltip visually more consistent within
> Plasma 5.
> 
> 
> Diffs
> -----
> 
>   libs/declarative/networkstatus.cpp d2dfd58a5cf44932683bc91bd961d0d3247d42bb 
> 
> Diff: https://git.reviewboard.kde.org/r/122835/diff/
> 
> 
> Testing
> -------
> 
> Confirmed tooltips lay out correctly.
> 
> 
> File Attachments
> ----------------
> 
> original tooltips
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/05/42eb466a-aa7e-43f9-8e8b-7c8d42f7da3f__nm-old.png
> new tooltip
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/05/a8c4e839-1b13-4203-a360-d86adc012ab6__nm-new.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150305/8263b9c2/attachment.html>


More information about the kde-networkmanager mailing list