Review Request 124485: Add missing traffic monitor

[Jan Grulich]

> On Čec. 27, 2015, 12:57 odp., Lamarque Souza wrote:
> > applet/contents/ui/ConnectionItem.qml, line 306
> > <https://git.reviewboard.kde.org/r/124485/diff/1/?file=388017#file388017line306>
> >
> >     what's the update rate used here? I think it is still 1 second. The old Plasma NM used to use 2 seconds instead. Increasing the update time can also help with the update overhead.

Also 2 seconds.


> On Čec. 27, 2015, 12:57 odp., Lamarque Souza wrote:
> > applet/contents/ui/ConnectionItem.qml, line 346
> > <https://git.reviewboard.kde.org/r/124485/diff/1/?file=388017#file388017line346>
> >
> >     I do not understand why returning when source name is found. Sorry for not looking at DataSource documentation for the answer but my laptop is malfunctioning. I am doing this review from my tablet.

Hmm, I don't remember right now, but I guess it checks whether the sourceName starts with "network/interfaces/DeviceName".


> On Čec. 27, 2015, 12:57 odp., Lamarque Souza wrote:
> > applet/contents/ui/ConnectionItem.qml, line 519
> > <https://git.reviewboard.kde.org/r/124485/diff/1/?file=388017#file388017line519>
> >
> >     so at least write the original file path you copied that from.

Ok, will do that.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124485/#review83041
-----------------------------------------------------------


On Čec. 27, 2015, 1:08 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124485/
> -----------------------------------------------------------
> 
> (Updated Čec. 27, 2015, 1:08 odp.)
> 
> 
> Review request for Network Management, Plasma and KDE Usability.
> 
> 
> Bugs: 333070
>     http://bugs.kde.org/show_bug.cgi?id=333070
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ConnectionItem.qml ff722a7 
> 
> Diff: https://git.reviewboard.kde.org/r/124485/diff/
> 
> 
> Testing
> -------
> 
> ![Traffic monitor](https://jgrulich.fedorapeople.org/plotter.png)
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150727/d92b9c9a/attachment-0001.html>