Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------

(Updated Čec. 23, 2015, 3:12 odp.)


Review request for Network Management and Plasma.


Changes
-------

Property was renamed as Lamarque suggested and the button dissappears after the applet is closed.


Bugs: 348905
    http://bugs.kde.org/show_bug.cgi?id=348905


Repository: plasma-nm


Description
-------

Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.


Diffs (updated)
-----

  applet/contents/ui/ConnectionItem.qml 3fa93b5 
  applet/contents/ui/PopupDialog.qml 2a0d352 

Diff: https://git.reviewboard.kde.org/r/124314/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150723/c2f2d450/attachment.html>