Review Request 122012: Add support for storing Openconnect secrets to KWallet

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122012/
-----------------------------------------------------------

(Updated Led. 13, 2015, 2:43 odp.)


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Update diff. I've found another approach which should be more simple and actually uses NM to handle storing secrets into KWallet.


Bugs: 309931 and 334474
    http://bugs.kde.org/show_bug.cgi?id=309931
    http://bugs.kde.org/show_bug.cgi?id=334474


Repository: plasma-nm


Description
-------

This patch adds support for storing secrets to KWallet from Openconnect auth dialog, which is the only part where secrets could be stored. It should behave similar to nm-openconnect, which means that all secrets which are OC_FORM_OPT_PASSWORD are stored to KWallet or they are not stored at all. I know I should avoid using synchronous calls when opening KWallet, but in this case it would be probably complicated to use it asynchronously.


Diffs (updated)
-----

  kded/secretagent.cpp 67e929f 
  vpn/openconnect/openconnectauth.cpp ebce2be 
  vpn/openconnect/openconnectwidget.cpp f9bc3cf 

Diff: https://git.reviewboard.kde.org/r/122012/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150113/bb877657/attachment.html>