Review Request 122012: Add support for storing Openconnect secrets to KWallet

[Lamarque Souza]

> On Jan. 12, 2015, 12:30 p.m., Lukáš Tinkl wrote:
> > Ship It!
> 
> Lamarque Souza wrote:
>     The big problem with using synchronous API is blocking the entire Plasma Desktop sometimes. That is very annoying from user point of view.
> 
> Jan Grulich wrote:
>     It shouldn't block plasma-desktop or plasmashell in case of Plasma 5. This is called either from our kded module or from the connection editor.

blocking a kded module is what indirectly blocks plasma shell. If any plasma applet does a sync call to kded then the entire plasma shell will be blocked if kded is blocked waiting for the wallet to be opened. I just do not know if there is any Plasma 5 applet doing sync calls to kded5. If there is none then this patch is good to go.


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122012/#review73841
-----------------------------------------------------------


On Jan. 12, 2015, 11:35 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122012/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 11:35 a.m.)
> 
> 
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This patch adds support for storing secrets to KWallet from Openconnect auth dialog, which is the only part where secrets could be stored. It should behave similar to nm-openconnect, which means that all secrets which are OC_FORM_OPT_PASSWORD are stored to KWallet or they are not stored at all. I know I should avoid using synchronous calls when opening KWallet, but in this case it would be probably complicated to use it asynchronously.
> 
> 
> Diffs
> -----
> 
>   kded/passworddialog.cpp 96cc789 
>   libs/editor/connectiondetaileditor.cpp ee9bced 
>   libs/editor/widgets/settingwidget.h 8d07b73 
>   libs/editor/widgets/settingwidget.cpp c876e79 
>   vpn/openconnect/openconnectauth.cpp ebce2be 
>   vpn/openconnect/openconnectwidget.cpp f9bc3cf 
> 
> Diff: https://git.reviewboard.kde.org/r/122012/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150112/78b38cab/attachment.html>