Review Request 122012: Add support for storing Openconnect secrets to KWallet

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122012/
-----------------------------------------------------------

(Updated Led. 12, 2015, 11:35 dop.)


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Add diff, it previously failed to load it.


Repository: plasma-nm


Description
-------

This patch adds support for storing secrets to KWallet from Openconnect auth dialog, which is the only part where secrets could be stored. It should behave similar to nm-openconnect, which means that all secrets which are OC_FORM_OPT_PASSWORD are stored to KWallet or they are not stored at all. I know I should avoid using synchronous calls when opening KWallet, but in this case it would be probably complicated to use it asynchronously.


Diffs (updated)
-----

  kded/passworddialog.cpp 96cc789 
  libs/editor/connectiondetaileditor.cpp ee9bced 
  libs/editor/widgets/settingwidget.h 8d07b73 
  libs/editor/widgets/settingwidget.cpp c876e79 
  vpn/openconnect/openconnectauth.cpp ebce2be 
  vpn/openconnect/openconnectwidget.cpp f9bc3cf 

Diff: https://git.reviewboard.kde.org/r/122012/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150112/ebf9d062/attachment.html>