Review Request 126398: Autodetect wireless security in the connection editor once SSID is selected/written

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126398/#review89655
-----------------------------------------------------------



libs/editor/settings/wifisecurity.cpp (line 317)
<https://git.reviewboard.kde.org/r/126398/#comment61401>

    "case" should vertically align with "switch".
    
    This switch case can be removed since the switch statement defaults to None.



libs/editor/settings/wifisecurity.cpp (line 318)
<https://git.reviewboard.kde.org/r/126398/#comment61402>

    The "// None" is redundant here. You can remove it.


- Lamarque Souza


On Dec. 17, 2015, 1:28 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126398/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 1:28 p.m.)
> 
> 
> Review request for Network Management and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> 1) This patch improves SsidCombobox to send ssidChanged() signal just once and not three times as it was before. Previously this signal was send in onCurrentIndexChanged() (second call) which calls setEditText() and thus editTextChanged() sent it one more time (third call) and the very first one was again in editTextChanged() which was called internally once user picked up any SSID from the combobox and this one included the ugly SSID name in format "ssid (%xx), Security: foo, Frequency: bar" which is the reason why I added check for this text in editTextChanged() to avoid sending this one. Another improvement in SsidCombobox is that it nows properly reloads BSSID combobox once SSID is changed by either selecting any SSID from the list or by writing any text into the SSID field.
> 
> 2) Adds detection for wireless security based on selected SSID
> 
> 
> Diffs
> -----
> 
>   libs/editor/connectiondetaileditor.cpp 7370bbb 
>   libs/editor/settings/wificonnectionwidget.h a111b7a 
>   libs/editor/settings/wificonnectionwidget.cpp a36b661 
>   libs/editor/widgets/ssidcombobox.h 3e367e7 
>   libs/editor/widgets/ssidcombobox.cpp 472384f 
>   libs/editor/settings/wifisecurity.h 2bef9c5 
>   libs/editor/settings/wifisecurity.cpp a6c252e 
> 
> Diff: https://git.reviewboard.kde.org/r/126398/diff/
> 
> 
> Testing
> -------
> 
> Tested with all security types (WEP/WPA/WPA Enterprise) and seems to work, also the SSID combobox now sends the ssidChanged() signal just once with correct SSID.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20151217/6e826332/attachment-0001.html>