Review Request 124747: Fix random MAC generation on Wired/WiFi

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124747/#review83854
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza


On Aug. 15, 2015, 7:03 p.m., Boudhayan Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124747/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2015, 7:03 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Randomly generated MAC addresses aren't truly random; they should have an even first octet (LSB set to 0) to signify that this is an Unicast address, and the second least-significant-bit should be set to 1 to specify that it is a locally administered MAC, not a globally enforced one.
> 
> Setting the Multicast bit (current behaviour half the time) will result in the kernel refusing to set the randomly generated MAC address, with a small entry in Journalctl/Syslog:
> 
> [platform/nm-linux-platform.c:2782] do_change_link(): platform-linux: do-change-link: failure changing link 3: Invalid address for specified address family (19)
> 
> This small patch fixes random MAC generation for both Wired and WiFi connections
> 
> 
> Diffs
> -----
> 
>   libs/editor/settings/wificonnectionwidget.cpp d22fda0 
>   libs/editor/settings/wiredconnectionwidget.cpp 80523ef 
> 
> Diff: https://git.reviewboard.kde.org/r/124747/diff/
> 
> 
> Testing
> -------
> 
> Builds, correctly generates random MACs with last two bits of first octet set to 10, saves said MAC.
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150815/37dd3248/attachment.html>