Review Request 120313: Do not keep trying to open KWallet if we failed before

[Jan Grulich]

> On Zář. 22, 2014, 12:18 odp., Lamarque Souza wrote:
> > kded/secretagent.cpp, line 259
> > <https://git.reviewboard.kde.org/r/120313/diff/1/?file=314383#file314383line259>
> >
> >     Ok, your patch works. However, in case of processGetSecrets() it will show a password dialog *for every request* that needs secrets, which I do not think users are going to like.
> >     
> >     Anyway, we should warn the user that kwallet is not working or he/she will just cancel the password dialog and try again. Think that most kwallet users use it so they do not need to remember their passwords. Just showing a password dialog when kwallet fails is not a good usability action in my opinion.
> 
> Jan Grulich wrote:
>     Why for every request? It should show a password dialog only when we fail to open KWallet. In case that KWallet is opened successfuly it should get secrets correctly and not continue with showing a dialog.
> 
> Lamarque Souza wrote:
>     Ok, I see that processGetSecrets() never opens a second dialog, so the dialog is not a issue. I am still not comfortable in just showing a password when kwallet fails to open.

I agree, but how do you want to inform users about that? We could use either notification or print some error into logs.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120313/#review67189
-----------------------------------------------------------


On Zář. 22, 2014, 11:38 dop., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120313/
> -----------------------------------------------------------
> 
> (Updated Zář. 22, 2014, 11:38 dop.)
> 
> 
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> In the secret agent, if any of functions for processing secrets fails to open KWallet, then m_wallet will be always set to 0, which leads again to another attempt to open KWallet. We should check if opening of KWallet failed before and do not try to open it again, which should be done in my patch.
> 
> BUG: https://bugs.kde.org/show_bug.cgi?id=339223
> 
> 
> Diffs
> -----
> 
>   kded/secretagent.h a438191 
>   kded/secretagent.cpp 77438ca 
> 
> Diff: https://git.reviewboard.kde.org/r/120313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140922/fa432335/attachment-0001.html>