Review Request 120082: delay the notifications and secret agent initializations until needed

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120082/#review65949
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza


On Set. 7, 2014, 8:37 a.m., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120082/
> -----------------------------------------------------------
> 
> (Updated Set. 7, 2014, 8:37 a.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Bugs: 338513
>     http://bugs.kde.org/show_bug.cgi?id=338513
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Move the initializations until it's really needed, into handler. That way both the applet and editor get the passwords and at the same time don't block the Plasma Shell startup. More info in the bugreport below
> 
> 
> BUG: 338513
> 
> 
> Diffs
> -----
> 
>   kded/service.h 01b13606eb3662b83dd5f39e3ffcbc0e9aeaf64f 
>   kded/service.cpp 5dfbc03d2ccb570eac397976f553acebe6d0a357 
>   libs/handler.h 5436281603666977b007b7d553b22d9dcbe6a043 
>   libs/handler.cpp 07737276f698d2ba26bb3c3250d60524a40bc3fd 
> 
> Diff: https://git.reviewboard.kde.org/r/120082/diff/
> 
> 
> Testing
> -------
> 
> Tested with both plasmashell and standalone plasma-nm-connection editor, even without kded5 running
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140907/cd990b08/attachment-0001.html>