Review Request 120483: Use regular IconItem for CompactRepresentation

Fri Oct 3 16:58:45 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120483/
-----------------------------------------------------------

Review request for Network Management and Jan Grulich.

Repository: plasma-nm

Description
-------

Since Plasma-NM just displays a single icon with a well-defined name (network-foo-bar-123-baz) there's no need to use a custom SvgItem.

Also, IconItem handles the icon size automatically removing the need for units.roundToIconSize. BusyIndicator is square also and so anchors.fill doesn't skew it.

Diffs
-----

  applet/contents/ui/CompactRepresentation.qml 8c1dd68 

Diff: https://git.reviewboard.kde.org/r/120483/diff/

Testing
-------

Tested on WiFi, should probably be tested on mobile and VPN but I don't see why this should cause trouble.

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20141003/f514870b/attachment.html>