Review Request 118980: Add Local Port selector to VPNC advanced settings dialog
Lamarque Souza
lamarque at kde.org
Sat Jun 28 15:49:10 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118980/#review61144
-----------------------------------------------------------
Ship it!
Ship It!
- Lamarque Souza
On June 28, 2014, 7:38 a.m., Michal Malý wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118980/
> -----------------------------------------------------------
>
> (Updated June 28, 2014, 7:38 a.m.)
>
>
> Review request for Network Management, Jan Grulich and Lukáš Tinkl.
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> This trivial patch adds a spinbox to VPNC advanced settings widget that allows the user to select which Local Port will the VPNC service try to bind.
>
>
> Diffs
> -----
>
> vpn/vpnc/vpncadvanced.ui 1c541f4
> vpn/vpnc/vpncadvancedwidget.cpp 9f86c0e
>
> Diff: https://git.reviewboard.kde.org/r/118980/diff/
>
>
> Testing
> -------
>
> The setting seems to be saved and loaded properly. Wireshark logs show that the correct Local Port is used. VPNC will use a random port if the value is set to zero.
>
>
> Thanks,
>
> Michal Malý
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140628/3db64ded/attachment.html>
More information about the kde-networkmanager
mailing list