Review Request 118980: Add Local Port selector to VPNC advanced settings dialog

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118980/#review61116
-----------------------------------------------------------



vpn/vpnc/vpncadvanced.ui
<https://git.reviewboard.kde.org/r/118980/#comment42564>

    Add this property to this QLabel:
    
    <property name="buddy">
     <cstring>localport</cstring>
    </property>
    



vpn/vpnc/vpncadvanced.ui
<https://git.reviewboard.kde.org/r/118980/#comment42565>

    Add this property here:
    
    <property name="specialValueText">
     <string>random</string>
    </property>
    
    
    According to the HIG [1] we should also use a slider here. Actually, the KIntNumInput class already supports showing a spinbox, but the spinbox's width is shrunk to the minimum when we do that. Consequently the "random" string in the property we just added is not entirely visible. Maybe we should fix that in KIntNumInput first before using a slider, so it is not necessary to add a slider in this patch.
    
    [1] http://techbase.kde.org/Projects/Usability/HIG


- Lamarque Souza


On June 27, 2014, 11:43 p.m., Michal Malý wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118980/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 11:43 p.m.)
> 
> 
> Review request for Network Management, Jan Grulich and Lukáš Tinkl.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This trivial patch adds a spinbox to VPNC advanced settings widget that allows the user to select which Local Port will the VPNC service try to bind.
> 
> 
> Diffs
> -----
> 
>   vpn/vpnc/vpncadvanced.ui 1c541f4 
>   vpn/vpnc/vpncadvancedwidget.cpp 9f86c0e 
> 
> Diff: https://git.reviewboard.kde.org/r/118980/diff/
> 
> 
> Testing
> -------
> 
> The setting seems to be saved and loaded properly. Wireshark logs show that the correct Local Port is used. VPNC will use a random port if the value is set to zero.
> 
> 
> Thanks,
> 
> Michal Malý
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140628/40d1b93b/attachment.html>