Review Request 119392: Missing Control For ModemManager

Ömer Fadıl Usta omerusta at gmail.com
Tue Jul 22 08:03:46 UTC 2014



> On July 22, 2014, 10:09 a.m., Jan Grulich wrote:
> > Ship It!
> 
> Jan Grulich wrote:
>     Can you please push it to master, Plasma/5.0 and 0.9.3 branches? Thanks a lot.

committed to 0.9.3 then cherrypicked to Plasma/5.0 then again cherrypicked to master
I hope i did correctly


- Ömer Fadıl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119392/#review62842
-----------------------------------------------------------


On July 22, 2014, 10:49 a.m., Ömer Fadıl Usta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119392/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 10:49 a.m.)
> 
> 
> Review request for Network Management and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> There was a missing control whether if Modemmanager exist or not before creating a ref
> 
> 
> Diffs
> -----
> 
>   kded/service.cpp a12ff76 
> 
> Diff: https://git.reviewboard.kde.org/r/119392/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ömer Fadıl Usta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140722/789acec2/attachment.html>


More information about the kde-networkmanager mailing list