Review Request 121304: Move all propertiesChanged() slots from public API to private classes
Lamarque Souza
lamarque at kde.org
Mon Dec 1 12:57:39 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121304/#review71154
-----------------------------------------------------------
src/device.cpp
<https://git.reviewboard.kde.org/r/121304/#comment49724>
Use C++ casting style.
src/device.cpp
<https://git.reviewboard.kde.org/r/121304/#comment49714>
Remove this commented line.
src/dhcp6config_p.h
<https://git.reviewboard.kde.org/r/121304/#comment49720>
code style: remove the space before "q".
src/gredevice.cpp
<https://git.reviewboard.kde.org/r/121304/#comment49721>
Use C++ casting instead of C.
src/gredevice.cpp
<https://git.reviewboard.kde.org/r/121304/#comment49722>
Same here.
src/gredevice.cpp
<https://git.reviewboard.kde.org/r/121304/#comment49727>
C++ casting style.
src/gredevice.cpp
<https://git.reviewboard.kde.org/r/121304/#comment49728>
C++ casting style.
src/vpnconnection.cpp
<https://git.reviewboard.kde.org/r/121304/#comment49723>
Use C++ casting style.
src/vpnconnection.cpp
<https://git.reviewboard.kde.org/r/121304/#comment49715>
camel case in "new_state" please.
- Lamarque Souza
On Dec. 1, 2014, 11:12 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121304/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 11:12 a.m.)
>
>
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
>
>
> Repository: libnm-qt
>
>
> Description
> -------
>
> As David Edmunson suggested, I removed all propertiesChanged() slots from all classes and moved them to their private classes. This needs to be properly checked if I didn't break anything.
>
> I also properly implemented all virtual devices to match the implementation of other devices.
>
>
> Diffs
> -----
>
> src/accesspoint.h b4b08e7
> src/accesspoint.cpp b058bbd
> src/accesspoint_p.h PRE-CREATION
> src/activeconnection.h 91c192c
> src/activeconnection.cpp 278ab12
> src/activeconnection_p.h fb726af
> src/adsldevice.h fb4f44b
> src/adsldevice.cpp 102db82
> src/adsldevice_p.h PRE-CREATION
> src/bluetoothdevice.h ac7014a
> src/bluetoothdevice.cpp e22bdcf
> src/bluetoothdevice_p.h 201944a
> src/bonddevice.h 5756fc4
> src/bonddevice.cpp d83b141
> src/bonddevice_p.h PRE-CREATION
> src/bridgedevice.h a0fb3ac
> src/bridgedevice.cpp e9dae46
> src/bridgedevice_p.h PRE-CREATION
> src/connection.h 8b83f29
> src/connection.cpp a2b8afd
> src/connection_p.h PRE-CREATION
> src/device.h 2013d1f
> src/device.cpp b87b0a8
> src/device_p.h 059f6ef
> src/dhcp4config.h 9f87b10
> src/dhcp4config.cpp da92b02
> src/dhcp4config_p.h 8c1bb68
> src/dhcp6config.h 7f4d528
> src/dhcp6config.cpp a4a41fc
> src/dhcp6config_p.h e287d6a
> src/genericdevice.h d954c9e
> src/genericdevice.cpp d940f42
> src/genericdevice_p.h PRE-CREATION
> src/gredevice.h 6472b0e
> src/gredevice.cpp d9468aa
> src/gredevice_p.h PRE-CREATION
> src/infinibanddevice.h 152c773
> src/infinibanddevice.cpp ea04ebd
> src/infinibanddevice_p.h PRE-CREATION
> src/macvlandevice.h 19111c1
> src/macvlandevice.cpp ef7f521
> src/macvlandevice_p.h PRE-CREATION
> src/modemdevice.h 0205f48
> src/modemdevice.cpp 6d6ba04
> src/modemdevice_p.h beaf2a6
> src/olpcmeshdevice.h b08813b
> src/olpcmeshdevice.cpp 814026c
> src/olpcmeshdevice_p.h da436d9
> src/teamdevice.h 85ab0f6
> src/teamdevice.cpp 8de1df1
> src/teamdevice_p.h PRE-CREATION
> src/tundevice.h fcd1138
> src/tundevice.cpp dcfdbe4
> src/tundevice_p.h PRE-CREATION
> src/vethdevice.h bcf17d8
> src/vethdevice.cpp edab51e
> src/vethdevice_p.h PRE-CREATION
> src/vlandevice.h eca01bf
> src/vlandevice.cpp 8f5a1fc
> src/vlandevice_p.h PRE-CREATION
> src/vpnconnection.h eae7a26
> src/vpnconnection.cpp 3015835
> src/vpnconnection_p.h PRE-CREATION
> src/wimaxdevice.h c7a616c
> src/wimaxdevice.cpp 4d9cb66
> src/wimaxdevice_p.h 1aa767b
> src/wimaxnsp.h 92f114c
> src/wimaxnsp.cpp 47ca40b
> src/wimaxnsp_p.h PRE-CREATION
> src/wireddevice.h c3a91da
> src/wireddevice.cpp 7835763
> src/wireddevice_p.h 72411a2
> src/wirelessdevice.h ce68244
> src/wirelessdevice.cpp c80ff22
> src/wirelessdevice_p.h 63c403b
> src/wirelessnetwork.h b78a64b
>
> Diff: https://git.reviewboard.kde.org/r/121304/diff/
>
>
> Testing
> -------
>
> I'm using it now with plasma-nm and it seems to work as before.
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20141201/2bc7401d/attachment-0001.html>
More information about the kde-networkmanager
mailing list