Review Request 109769: Use UTF8 encoding for SSIDs
Ralf Jung
post+kde at ralfj.de
Wed Mar 27 20:16:27 UTC 2013
> On March 27, 2013, 8:20 p.m., Lamarque Vieira Souza wrote:
> > Ship It!
>
> Lukáš Tinkl wrote:
> We just fixed it today in libnm-qt/settings branch btw
I pushed stuff to libnm-qt/master and networkmanagement/nm09 - however these branches relate to the settings one... ;-)
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109769/#review29964
-----------------------------------------------------------
On March 27, 2013, 8:30 p.m., Ralf Jung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109769/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 8:30 p.m.)
>
>
> Review request for Network Management and Lamarque Vieira Souza.
>
>
> Description
> -------
>
> This patch changes the encoding used for SSIDs to UTF8. IMHO that's the only internationally sensible choice. For example, the hotspot of a friend's iPad used UTF8. The Gnome NM frontend displayed that SSID correctly.
>
> I also have the same patch available for libnm-qt (in file accesspoint.cpp), so I could push that as well.
>
>
> Diffs
> -----
>
> solidcontrolfuture/solid/networkmanager-0.9/accesspoint.cpp bb3c9e1
>
> Diff: http://git.reviewboard.kde.org/r/109769/diff/
>
>
> Testing
> -------
>
> Verified that the mentioned iPhone hotspot is now displayed correctly.
>
>
> Thanks,
>
> Ralf Jung
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130327/88afb858/attachment.html>
More information about the kde-networkmanager
mailing list