Review Request: Add option to configure IPv6 Privacy Extension
Lamarque Vieira Souza
lamarque at kde.org
Fri Jan 4 10:54:47 UTC 2013
> On Jan. 1, 2013, 4:47 p.m., Ralf Jung wrote:
> > I just noticed (from looking at the NetworkManager source code) that -1 actually is a valid value for the "ip6-privacy" option. It means "unknown". However, if I understand the code applying that configuration properly, "unknown" and "disabled" are treated exactly the same. Please let me know how I should deal with that in the GUI.
How does nm-applet deal with that? I think calling "disabled" is better than "unknown" if they really behave the same.
- Lamarque Vieira
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108064/#review24367
-----------------------------------------------------------
On Jan. 3, 2013, 6:17 p.m., Ralf Jung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108064/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2013, 6:17 p.m.)
>
>
> Review request for Network Management.
>
>
> Description
> -------
>
> This patch adds an option to the IPv6 configuration screen to change the IPv6 Privacy Extension configuration.
>
> The option is implemented as documented at http://projects.gnome.org/NetworkManager/developers/api/09/ref-settings.html . However, that document says the default value is "-1", while it also says that only 0, 1 and 2 are valid for this option. Therefore, I chose 0 to be the default in the Knm::Ipv6Setting class, but the option is always put into the NM config map - even if it is zero.
>
>
> This addresses bug 312305.
> http://bugs.kde.org/show_bug.cgi?id=312305
>
>
> Diffs
> -----
>
> backends/NetworkManager/settings/ipv6dbus.cpp 8c846ab
> libs/internals/settings/ipv6.h 2eadf69
> libs/internals/settings/ipv6.cpp 590274b
> libs/ui/ipv6.ui 56a1248
> libs/ui/ipv6widget.cpp 36b6885
>
> Diff: http://git.reviewboard.kde.org/r/108064/diff/
>
>
> Testing
> -------
>
> I verified that whatever I configure in the applet ends up in the /etc/NetworkManager/system-connections files.
>
> I could not yet test whether the extensions are actually properly enabled and disabled because the network I am currently in does not use IPv6. However, next week I will be at university again where I should be able to test this.
>
>
> Thanks,
>
> Ralf Jung
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130104/f7440d34/attachment-0001.html>
More information about the kde-networkmanager
mailing list