Review Request 108941: Missing password field in password dialog when using wpa2 connections

[Jan Grulich]

> On Feb. 13, 2013, 1:38 p.m., Lamarque Vieira Souza wrote:
> >

I think your solution and the previous patch is useless, because it has no effect. It will always return an empty list. It works only when the password is missing, then needSecrets() method will return a non-empty list with secrets.


> On Feb. 13, 2013, 1:38 p.m., Lamarque Vieira Souza wrote:
> > libs/ui/security/security8021xauth.cpp, line 58
> > <http://git.reviewboard.kde.org/r/108941/diff/1/?file=113890#file113890line58>
> >
> >     I am wondering why needSecrets() returns empty. Long ago I added a hack to make sure it returns a non-empty QStringList, it seems something else is missing. Can you try the patch in http://paste.kde.org/670268/ without this patch applied and check if it also solves the problem?

It returns an empty list, because in needSecrets() method is a condition where we test if required password is empty, but it is not because it is entered incorrectly.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108941/#review27363
-----------------------------------------------------------


On Feb. 13, 2013, 11:02 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108941/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 11:02 a.m.)
> 
> 
> Review request for Network Management and Lamarque Vieira Souza.
> 
> 
> Description
> -------
> 
> The dialog was created by the needed secrets. When the user entered the wrong password then secrets were empty so we have to use another way to find out what password we need. Tested on eduroam and it seems that it works without a problem.
> 
> 
> This addresses bug 299868.
>     http://bugs.kde.org/show_bug.cgi?id=299868
> 
> 
> Diffs
> -----
> 
>   libs/ui/security/security8021xauth.cpp 5c67355 
> 
> Diff: http://git.reviewboard.kde.org/r/108941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130213/afce6d21/attachment-0001.html>