Review Request: Enable additional DNS details for IPv4 Automatic Method

[Rajeesh K Nambiar]

> On Sept. 22, 2012, 7:17 p.m., Lamarque Vieira Souza wrote:
> > libs/ui/ipv4widget.cpp, line 389
> > <http://git.reviewboard.kde.org/r/106532/diff/1/?file=86804#file86804line389>
> >
> >     Does this really work with NetworkManager? I mean, does NetworkManager really append the additional dns servers and search domains or it just ignores this configuration? Does it show any warning/error messages in its log?
> >     
> >     Anyway, you need to implement this same thing for the IPv6 part as well.

It does work with NetworkManager (0.9.4.0-9.git20120521), no errors or issues.

A question though - should the labels ("Additional &DNS Servers") be in i8n()?


- Rajeesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106532/#review19329
-----------------------------------------------------------


On Sept. 22, 2012, 4:45 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106532/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2012, 4:45 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Description
> -------
> 
> Enable additional DNS details (Additional DNS Servers, Additional Domain Search Names) for IPv4 Automatic Method also.
> 
> 
> Diffs
> -----
> 
>   libs/ui/ipv4widget.cpp 47d73e1 
> 
> Diff: http://git.reviewboard.kde.org/r/106532/diff/
> 
> 
> Testing
> -------
> 
> Against nm09 branch, KDE SC 4.8.5
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120923/14e30819/attachment.html>