Review Request: Improve Wireless Auth dialog

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106437/#review19002
-----------------------------------------------------------



libs/ui/security/wirelesssecurityauth.cpp
<http://git.reviewboard.kde.org/r/106437/#comment15087>

    move this include to after #include "wpaauthwidget.h"



libs/ui/security/wirelesssecurityauth.cpp
<http://git.reviewboard.kde.org/r/106437/#comment15086>

    Use i18nc here with "@title:window" as first parameter.



libs/ui/security/wirelesssecurityauth.cpp
<http://git.reviewboard.kde.org/r/106437/#comment15088>

    Use IconSize(KIconLoader::Dialog) instead of hard-coded value 60.



libs/ui/security/wirelesssecurityauth.cpp
<http://git.reviewboard.kde.org/r/106437/#comment15085>

    how is this QWidget deallocated if you are not passing a parent?


- Lamarque Vieira Souza


On Sept. 13, 2012, 9:52 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106437/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2012, 9:52 a.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Description
> -------
> 
> Fix a bug in which the wireless password prompt dialog would be shown at an incorrect size
>  
> Added a title and icon to the dialog so that it's clear when it pops up to the
> user what the prompt is for.
> 
> 
> Diffs
> -----
> 
>   libs/ui/CMakeLists.txt 42ae858 
>   libs/ui/security/wirelesssecurityauth.cpp b61d14a 
>   libs/ui/security/wirelesssecurityauth.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106437/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple WPA and WEP connections.
> 
> 
> Screenshots
> -----------
> 
> After
>   http://git.reviewboard.kde.org/r/106437/s/726/
> Before
>   http://git.reviewboard.kde.org/r/106437/s/727/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120915/5eead8b1/attachment-0001.html>