Review Request: Update against new NetworkManager

Jan Grulich grulja at gmail.com
Mon Oct 15 16:05:46 UTC 2012



> On Oct. 15, 2012, 3:57 p.m., Lamarque Vieira Souza wrote:
> > activeconnection.h, line 76
> > <http://git.reviewboard.kde.org/r/106852/diff/5/?file=89968#file89968line76>
> >
> >     it looks like this master device has nothing to do with vpn, sorry. You can drop the change in the comment. Do you have write access to push this patch to the repo?

Yes, I have write access.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106852/#review20391
-----------------------------------------------------------


On Oct. 15, 2012, 7:30 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106852/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 7:30 a.m.)
> 
> 
> Review request for Network Management and Lamarque Vieira Souza.
> 
> 
> Description
> -------
> 
> This patch updates libnm-qt against new NetworkManager
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0a8ab22 
>   activeconnection.h 1a0867f 
>   activeconnection.cpp 4869de8 
>   activeconnection_p.h 59e545a 
>   dbus/generic-types.h 6544b39 
>   dbus/generic-types.cpp 95427d1 
>   dbus/introspection/nm-active-connection.xml c8bc08f 
>   dbus/introspection/nm-agent-manager.xml 0b1e3e6 
>   dbus/introspection/nm-device-wifi.xml 3acd3c9 
>   dbus/introspection/nm-device.xml 144c71b 
>   dbus/introspection/nm-manager.xml 13da873 
>   dbus/introspection/nm-secret-agent.xml 7786a76 
>   dbus/introspection/nm-settings.xml d0a1433 
>   dbus/introspection/nm-vpn-plugin.xml c7530b3 
>   dbus/nm-access-pointinterface.h 2d00925 
>   dbus/nm-access-pointinterface.cpp c491b74 
>   dbus/nm-active-connectioninterface.h bb58e11 
>   dbus/nm-active-connectioninterface.cpp c77a6a2 
>   dbus/nm-agent-managerinterface.h 9cbfc24 
>   dbus/nm-agent-managerinterface.cpp 02dd79c 
>   dbus/nm-device-btinterface.h e0a35c1 
>   dbus/nm-device-btinterface.cpp 9a78d08 
>   dbus/nm-device-ethernetinterface.h 9c9790f 
>   dbus/nm-device-ethernetinterface.cpp 7f979b7 
>   dbus/nm-device-modeminterface.h 550fff4 
>   dbus/nm-device-modeminterface.cpp 5f9bcf6 
>   dbus/nm-device-olpc-meshinterface.h bb26e8c 
>   dbus/nm-device-olpc-meshinterface.cpp 4d46db4 
>   dbus/nm-device-wifiinterface.h c026a96 
>   dbus/nm-device-wifiinterface.cpp 4a883e1 
>   dbus/nm-device-wimaxinterface.h 9f8373a 
>   dbus/nm-device-wimaxinterface.cpp 6d388f1 
>   dbus/nm-deviceinterface.h f2107d3 
>   dbus/nm-deviceinterface.cpp 8aad0e4 
>   dbus/nm-dhcp4-configinterface.h 0f5fe52 
>   dbus/nm-dhcp4-configinterface.cpp 05e9aab 
>   dbus/nm-dhcp6-configinterface.h cd155ac 
>   dbus/nm-dhcp6-configinterface.cpp 2784a82 
>   dbus/nm-ip4-configinterface.h 11776bb 
>   dbus/nm-ip4-configinterface.cpp d9809a9 
>   dbus/nm-ip6-configinterface.h dcdef9d 
>   dbus/nm-ip6-configinterface.cpp f0a3f15 
>   dbus/nm-managerinterface.h 8bef738 
>   dbus/nm-managerinterface.cpp 19172ec 
>   dbus/nm-secret-agentadaptor.h 26be7a6 
>   dbus/nm-secret-agentadaptor.cpp a111d45 
>   dbus/nm-settings-connectioninterface.h 58fdcc6 
>   dbus/nm-settings-connectioninterface.cpp f1514cb 
>   dbus/nm-settingsinterface.h 87f74d7 
>   dbus/nm-settingsinterface.cpp 06a8ff2 
>   dbus/nm-vpn-connectioninterface.h 41e6fc3 
>   dbus/nm-vpn-connectioninterface.cpp 7219529 
>   dbus/nm-vpn-managerinterface.h 806303d 
>   dbus/nm-vpn-plugininterface.h 787df1a 
>   dbus/nm-vpn-plugininterface.cpp 338bf3f 
>   dbus/nm-wimax-nspinterface.h 447ee90 
>   dbus/nm-wimax-nspinterface.cpp afc1533 
>   device.h 9323495 
>   device.cpp 958602f 
>   device_p.h a9640b7 
>   manager.h b2029bb 
>   manager.cpp 5cf3266 
>   manager_p.h bb377bd 
>   settings.h 818ef5b 
>   settings.cpp 0c76d51 
>   settings_p.h 1f6900b 
>   wirelessdevice.h b7ff859 
>   wirelessdevice.cpp 925d744 
> 
> Diff: http://git.reviewboard.kde.org/r/106852/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20121015/91e8733d/attachment-0001.html>


More information about the kde-networkmanager mailing list