Review Request: make the networkmanagement arthur branch high-res friendly

Michael Zanetti mzanetti at kde.org
Tue Nov 20 20:06:08 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107249/
-----------------------------------------------------------

(Updated Nov. 20, 2012, 8:06 p.m.)


Review request for Network Management.


Description
-------

This makes the arthur branch usable on high-res screens.

The QML interface really didn't adapt itself to different sizes at all. I had to change quite a bit. It could be that I changed the look of some small parts a little bit on my way, but I tried to keep the interface as much as possible to what it looked like before. It should be quite easy now to change the overall sizes by changing leftViewWidth, rightViewWidth and minimumHeight in NMPopup.qml.

The sizes of the UI elements are taken from a standard Plasma button and all the list items etc are adjusted to that. This way the items also scale nicely when the theme requires bigger buttons.

Hope this helps.


Diffs (updated)
-----

  applet/qml/ConnectionItem.qml a9d1b6d 
  applet/qml/ConnectionsListWidget.qml 1ee6428 
  applet/qml/ConnectionsTabWidget.qml 63a2913 
  applet/qml/DisconnectButton.qml 43bdcbe 
  applet/qml/GsmNetworkIcon.qml 71154dc 
  applet/qml/GsmNetworkItem.qml 3a4463a 
  applet/qml/HiddenWirelessNetwork.qml 2e20417 
  applet/qml/InterfaceItem.qml 6ce74b2 
  applet/qml/InterfacesListWidget.qml 3d0ea88 
  applet/qml/ModemInterfaceItem.qml 22a3c3f 
  applet/qml/NMPopup.qml 31a33c6 
  applet/qml/VpnInterfaceItem.qml c06e6ef 
  applet/qml/VpnNetworkItem.qml 66c81a4 
  applet/qml/WiredInterfaceIcon.qml 915518a 
  applet/qml/WiredInterfaceItem.qml 6be0f3c 
  applet/qml/WiredNetworkIcon.qml c0c8ca9 
  applet/qml/WiredNetworkItem.qml 046d02b 
  applet/qml/WirelessInterfaceIcon.qml dabebd1 
  applet/qml/WirelessInterfaceItem.qml 15ee0f1 
  applet/qml/WirelessNetworkIcon.qml b3bd523 
  applet/qml/WirelessNetworkItem.qml 90d5e8a 

Diff: http://git.reviewboard.kde.org/r/107249/diff/


Testing
-------


Thanks,

Michael Zanetti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20121120/ab9fe017/attachment.html>


More information about the kde-networkmanager mailing list