Review Request: libnm-qt requires libnm-glib to be built

Commit Hook null at kde.org
Fri Mar 16 16:21:21 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104171/#review11484
-----------------------------------------------------------


This review has been submitted with commit 6a52335473771bb3a83262e63806356dcdd415c8 by Lamarque V. Souza to branch master.

- Commit Hook


On March 6, 2012, 11:31 a.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104171/
> -----------------------------------------------------------
> 
> (Updated March 6, 2012, 11:31 a.m.)
> 
> 
> Review request for Network Management and Lamarque Vieira Souza.
> 
> 
> Description
> -------
> 
> libnm-qt requires libnm-glib to be built, so cmake should check its existence.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ef7ea12 
>   FindNetworkManager.cmake ced2017 
> 
> Diff: http://git.reviewboard.kde.org/r/104171/diff/
> 
> 
> Testing
> -------
> 
> * without libnm-glib installed, cmake now complains (instead of cmake completing successfully, and the build failing later, which was the case before)
> * with libnm-glib installed, compilation works fine
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120316/ae262394/attachment.html>


More information about the kde-networkmanager mailing list