Review Request: Import/Export Routes for VPN connections

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104141/#review11169
-----------------------------------------------------------


This review has been submitted with commit a8922b82c77d38e8deedb4f9ce118d2783b6cd96 by Lamarque V. Souza to branch nm09.

- Commit Hook


On March 4, 2012, 2:03 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104141/
> -----------------------------------------------------------
> 
> (Updated March 4, 2012, 2:03 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Description
> -------
> 
> Import/Export Routes setting for VPN connections from/to configuration files. Please review the Gateway/Metrics part in particular.
> 
> 
> Diffs
> -----
> 
>   libs/ui/vpnpreferences.cpp a8442ec 
>   settings/config/manageconnectionwidget.cpp dd8b406 
>   vpnplugins/openvpn/CMakeLists.txt ce9e1e6 
>   vpnplugins/openvpn/openvpn.cpp 05bb9ac 
>   vpnplugins/vpnc/CMakeLists.txt 5af39b9 
>   vpnplugins/vpnc/vpnc.cpp dc6bc58 
> 
> Diff: http://git.reviewboard.kde.org/r/104141/diff/
> 
> 
> Testing
> -------
> 
> Tested the import/export part, Routes appear properly in the new connection. I don't have a real configuration file to test :-/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120306/9ad011d2/attachment.html>