Review Request: add support for network zones

[Christoph Feck]

On Tuesday 26 June 2012 15:26:32 Lamarque V. Souza wrote:
> Em Tuesday 26 June 2012, Christoph Feck escreveu:
> > > On June 26, 2012, 11:06 a.m., Commit Hook wrote:
> > > > This review has been submitted with commit
> > > > 71cff79a2128b6e62e61555cc38383196bbeb540 by Lukas Tinkl to
> > > > branch nm09.
> > 
> > This commit caused build failure. I committed a fix, please
> > review if the UI patch is correct.
> 
> 	I think you have not pushed the commit.

I had pushed it to nm09 branch, because at that time, the review 
commit was not in master. Lukáš also corrected the patch before 
pushing to master, but it is now different in nm09 branch, likely 
because my commit was wrong.

Lukáš, can you please check and correct it?

> 
> > - Christoph
> > 
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/105324/#review15165
> > -----------------------------------------------------------
> > 
> > On June 25, 2012, 10:41 a.m., Lukáš Tinkl wrote:
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > http://git.reviewboard.kde.org/r/105324/
> > > -----------------------------------------------------------
> > > 
> > > (Updated June 25, 2012, 10:41 a.m.)
> > > 
> > > 
> > > Review request for Network Management and Lamarque Vieira
> > > Souza.
> > > 
> > > 
> > > Description
> > > -------
> > > 
> > > NetworkManager has had support for FirewallD [1] and Network
> > > Zones [2] since [3].
> > > 
> > > This patch adds one combo box that enables to change the
> > > network zone. This box is visible only when FirewallD is
> > > running.
> > > 
> > > [1] https://fedorahosted.org/firewalld/
> > > [2] https://fedoraproject.org/wiki/Features/network-zones
> > > [3]
> > > http://cgit.freedesktop.org/NetworkManager/NetworkManager/commi
> > > t/?id=1c0 aeb457546ac5e485ca21dfe23f1a009912701
> > > 
> > > (on behalf of Jiri Popelka <jpopelka at redhat.com>)
> > > 
> > > 
> > > Diffs
> > > -----
> > > 
> > >   backends/NetworkManager/connectiondbus.cpp 4649a19
> > >   libs/internals/connection.h 485b810
> > >   libs/internals/connection.cpp 67f31bc
> > >   libs/ui/connection.ui 7b9f873
> > >   libs/ui/connectionwidget.h aac7050
> > >   libs/ui/connectionwidget.cpp f67f157
> > > 
> > > Diff: http://git.reviewboard.kde.org/r/105324/diff/
> > > 
> > > 
> > > Testing
> > > -------
> > > 
> > > 
> > > Thanks,
> > > 
> > > Lukáš Tinkl