Review Request: add support for network zones

[Lamarque Vieira Souza]

> On June 22, 2012, 2:16 p.m., Lamarque Vieira Souza wrote:
> > backends/NetworkManager/connectiondbus.cpp, line 195
> > <http://git.reviewboard.kde.org/r/105324/diff/1/?file=70133#file70133line195>
> >
> >     Some NetworkManager settings when empty strings must not be added to the dbus map or NetworkManager invalidates the connection. Is this the case for NM_SETTING_CONNECTION_ZONE? If so then you must check if it is empty and do not add it   here if it is empty.
> >     
> >     I cannot answer if that is the case for NM_SETTING_CONNECTION_ZONE because that seems to be a implicit rule not described in the NetworkManager specification. You must look into NetworkManager source code to check if it the case for NM_SETTING_CONNECTION_ZONE.
> 
> Jiri Popelka wrote:
>     Actually yes, current NetworkManager invalidates the connection when NM_SETTING_CONNECTION_ZONE is empty. But it's a bug (caused by me) and I already sent patch to https://mail.gnome.org/archives/networkmanager-list/2012-June/msg00087.html

Anyway, Plasma NM needs to support older versions of NetworkManager (distributions are not that eager to use the latest NM version), so I think it is better not add NM_SETTING_CONNECTION_ZONE to the map if it is empty.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105324/#review14997
-----------------------------------------------------------


On June 22, 2012, 9:54 a.m., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105324/
> -----------------------------------------------------------
> 
> (Updated June 22, 2012, 9:54 a.m.)
> 
> 
> Review request for Network Management and Lamarque Vieira Souza.
> 
> 
> Description
> -------
> 
> NetworkManager has had support for FirewallD [1] and Network Zones [2]
> since [3].
> 
> This patch adds one combo box that enables to change the network zone.
> This box is visible only when FirewallD is running.
> 
> [1] https://fedorahosted.org/firewalld/
> [2] https://fedoraproject.org/wiki/Features/network-zones
> [3] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1c0aeb457546ac5e485ca21dfe23f1a009912701
> 
> (on behalf of Jiri Popelka <jpopelka at redhat.com>)
> 
> 
> Diffs
> -----
> 
>   backends/NetworkManager/connectiondbus.cpp 4649a19 
>   libs/internals/connection.h 485b810 
>   libs/internals/connection.cpp 67f31bc 
>   libs/ui/connection.ui 7b9f873 
>   libs/ui/connectionwidget.h aac7050 
>   libs/ui/connectionwidget.cpp f67f157 
> 
> Diff: http://git.reviewboard.kde.org/r/105324/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120622/66a3d0b4/attachment.html>