Review Request: add support for network zones

[Lamarque Vieira Souza]

> On July 8, 2012, 8:25 p.m., Kai Uwe Broulik wrote:
> > Could you check if your ifdefs are properly working?
> > On my machine, NM happily compiles but then refuses to create any connection (dropped me back in my workplan an entire week). When I removed that patch, it worked fine again.
> 
> Lamarque Vieira Souza wrote:
>     Do you have firewalld installed? The patch should not affect anyone without firewalld installed (like me).

I have just pushed a fix for the problem. Please test and check if it works now.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105324/#review15550
-----------------------------------------------------------


On June 25, 2012, 10:41 a.m., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105324/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 10:41 a.m.)
> 
> 
> Review request for Network Management and Lamarque Vieira Souza.
> 
> 
> Description
> -------
> 
> NetworkManager has had support for FirewallD [1] and Network Zones [2]
> since [3].
> 
> This patch adds one combo box that enables to change the network zone.
> This box is visible only when FirewallD is running.
> 
> [1] https://fedorahosted.org/firewalld/
> [2] https://fedoraproject.org/wiki/Features/network-zones
> [3] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1c0aeb457546ac5e485ca21dfe23f1a009912701
> 
> (on behalf of Jiri Popelka <jpopelka at redhat.com>)
> 
> 
> Diffs
> -----
> 
>   backends/NetworkManager/connectiondbus.cpp 4649a19 
>   libs/internals/connection.h 485b810 
>   libs/internals/connection.cpp 67f31bc 
>   libs/ui/connection.ui 7b9f873 
>   libs/ui/connectionwidget.h aac7050 
>   libs/ui/connectionwidget.cpp f67f157 
> 
> Diff: http://git.reviewboard.kde.org/r/105324/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120714/33914138/attachment.html>