Re: Review Request: Don’t show Access technology in tray icon while connecting as it obscures the connecting progress bar

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103828/
-----------------------------------------------------------

(Updated Jan. 30, 2012, 4:03 p.m.)


Review request for Network Management and Lamarque Vieira Souza.


Changes
-------

Corrected and added some missing stuff:
 - When disconnected it falls back to the generic cellphone icon instead of the empty bars with the space that is actually meant for the progress bar
 - When technology unknown or gprs and no signal strength available it keeps the cellphone icon while connecting (makes code a bit dirty unfortunately) to avoid flickering, i.e. changing from the cellphone icon to the empty signal bars while connecting and back to the cellphone when connected


Description
-------

On the KDE 4.8 release party some people argued that the access technology that is displayed below the signal strength bars makes the "connecting progress bar" hard to spot. This resolves this by hiding the access technology when not fully connected, i.e. when the bar is visible.
Also, my modem did always announce "UMTS" access technology and only when it is fully connected, then it changes to whatever HSDPA or GPRS is used.

You need the attached network2.svgz to have the appropriate icons for the above case.


Diffs (updated)
-----

  applet/networkmanager.cpp e75f2d5 

Diff: http://git.reviewboard.kde.org/r/103828/diff/diff


Testing
-------

Works as expected. When connecting, only the signal strength is shown but no access technology.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120130/8b398238/attachment.html>