Re: Review Request: Don’t show Access technology in tray icon while connecting as it obscures the connecting progress bar

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103828/#review10250
-----------------------------------------------------------


This review has been submitted with commit 11314591fa52dbdaabd88cbb305f47c5d9982c88 by Lamarque V. Souza to branch nm09.

- Commit Hook


On Jan. 30, 2012, 6:50 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103828/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2012, 6:50 p.m.)
> 
> 
> Review request for Network Management and Lamarque Vieira Souza.
> 
> 
> Description
> -------
> 
> On the KDE 4.8 release party some people argued that the access technology that is displayed below the signal strength bars makes the "connecting progress bar" hard to spot. This resolves this by hiding the access technology when not fully connected, i.e. when the bar is visible.
> Also, my modem did always announce "UMTS" access technology and only when it is fully connected, then it changes to whatever HSDPA or GPRS is used.
> 
> You need the attached network2.svgz to have the appropriate icons for the above case.
> 
> 
> Diffs
> -----
> 
>   applet/networkmanager.cpp e75f2d5 
> 
> Diff: http://git.reviewboard.kde.org/r/103828/diff/diff
> 
> 
> Testing
> -------
> 
> Works as expected. When connecting, only the signal strength is shown but no access technology.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120130/b0eed15d/attachment.html>