Re: Review Request: Don’t show Access technology in tray icon while connecting as it obscures the connecting progress bar

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103828/#review10237
-----------------------------------------------------------



applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/103828/#comment8431>

    remove trailing whitespace.



applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/103828/#comment8432>

    this call type is known for freezing the entire plasma desktop. I need to re-implement it before you can use it here.
    
    I also need to simplify this method. There are too many if's and switch's there.


- Lamarque Vieira Souza


On Jan. 30, 2012, 4:03 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103828/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2012, 4:03 p.m.)
> 
> 
> Review request for Network Management and Lamarque Vieira Souza.
> 
> 
> Description
> -------
> 
> On the KDE 4.8 release party some people argued that the access technology that is displayed below the signal strength bars makes the "connecting progress bar" hard to spot. This resolves this by hiding the access technology when not fully connected, i.e. when the bar is visible.
> Also, my modem did always announce "UMTS" access technology and only when it is fully connected, then it changes to whatever HSDPA or GPRS is used.
> 
> You need the attached network2.svgz to have the appropriate icons for the above case.
> 
> 
> Diffs
> -----
> 
>   applet/networkmanager.cpp e75f2d5 
> 
> Diff: http://git.reviewboard.kde.org/r/103828/diff/diff
> 
> 
> Testing
> -------
> 
> Works as expected. When connecting, only the signal strength is shown but no access technology.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120130/cb992e83/attachment.html>