Review Request: Updated code to fix "Enable ..." checkbox handling and simplify the code.
Lamarque Vieira Souza
lamarque at kde.org
Thu Feb 2 17:53:40 UTC 2012
> On Feb. 2, 2012, 4:15 p.m., Rex Dieter wrote:
> > I believe this has been fixed for quite awhile already, so this review should probably be closed.
Yes, it was fixed already. Please drop this request.
- Lamarque Vieira
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100835/#review10288
-----------------------------------------------------------
On March 10, 2011, 4:10 p.m., Jirka Klimes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100835/
> -----------------------------------------------------------
>
> (Updated March 10, 2011, 4:10 p.m.)
>
>
> Review request for Network Management.
>
>
> Description
> -------
>
> This patch fixes "Enable ..." checkbox handling and simplify the code.
>
> There was a bug that when Wifi was rfkilled by a hardware switch,
> knm unchecked the "Enable wireless" checkbox, but it also (erroneously)
> issued 'disable wireless' command, which caused NM to store 'wireless
> disabled' state as user preference. Then after enabling hardware switch
> WiFi stayed disabled.
> This is now fixed and the code is also simplified a bit.
>
> Would you review please?
>
> For Lamarque:
> I think that b1c517b2b42a62990b6f9dd5b96eb79659e9953b (saving config) is not necessary and may be contra-productive.
> NM itself stores user preference and there's no need applets do that. If there are more applets they will step on their toes.
> And in NM 0.9 will be perfectly possible to have more applets running.
> Nonetheless, thanks for your work on knm!
>
>
> Diffs
> -----
>
> applet/nmpopup.cpp 282299b
>
> Diff: http://git.reviewboard.kde.org/r/100835/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jirka Klimes
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120202/602f572e/attachment.html>
More information about the kde-networkmanager
mailing list