Review Request: Mobile Connection Wizard: A concept of i18n of APN's list

[Swami Dhyan Nataraj [Nikolay Shaplov]]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104349/
-----------------------------------------------------------

(Updated April 1, 2012, 6:06 a.m.)


Review request for Network Management and Lamarque Vieira Souza.


Description
-------

This is a kind of concept how to internationalize list of APNs in mobile connection wizard.

This concept uses less CPU and more memory (through this task is not resourse critical). It create a list of apn's QVatiant map once, and then uses it all the time till the end. I thought it is better then reparse XML each time we need an APL info.

If there are ant comments, I will try to do fixes. If no, and everything is OK, I will remove all commented out code from the patch, and let's commit it :-)


Diffs (updated)
-----

  settings/config/mobileconnectionwizard.h 77fdf56cdf1f9093bcb7052a6a19e6b1bb5ea184 
  settings/config/mobileconnectionwizard.cpp 1b31c59e0133d931723f0c98902828d98a36aea4 
  settings/config/mobileproviders.h 72189133fdb6e64edd3ca7736bdc4a2c4954d585 
  settings/config/mobileproviders.cpp 1ef26fcddeded9e612571a3fd4d1e0771e763bce 

Diff: http://git.reviewboard.kde.org/r/104349/diff/


Testing
-------


Thanks,

Swami Dhyan Nataraj [Nikolay Shaplov]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120401/efa642de/attachment.html>