Review Request: Make Network Manager show signal strength in system tray also for mobile broadband connections

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102827/#review7361
-----------------------------------------------------------


This review has been submitted with commit a366bfb3ae75092bba1768e786ea0345e20cde15 by Lamarque V. Souza to branch nm09.

- Commit Hook


On Oct. 13, 2011, 8:38 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102827/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2011, 8:38 a.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Description
> -------
> 
> As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
> This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
> I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.
> 
> I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.
> 
> 
> This addresses bug 283776.
>     http://bugs.kde.org/show_bug.cgi?id=283776
> 
> 
> Diffs
> -----
> 
>   applet/networkmanager.cpp 8c2dc2e 
> 
> Diff: http://git.reviewboard.kde.org/r/102827/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles and works okay.
> It is not yet perfect but I think it is a good start.
> 
> Known issues:
>  - The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
>  - When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)
> 
> 
> Screenshots
> -----------
> 
> HSDPA tray icon
>   http://git.reviewboard.kde.org/r/102827/s/289/
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111015/2fd97af5/attachment.html>