Review Request: [RFC] Import VPN connection

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101419/#review3471
-----------------------------------------------------------



settings/config/manageconnectionwidget.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2919>

    0 instead of NULL.



vpnplugins/vpnc/vpnc.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2917>

    Use 0 instead of NULL. NULL is used C, 0 is used in C++.



vpnplugins/vpnc/vpnc.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2918>

    0 instead of NULL.



vpnplugins/vpnc/vpnc.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2920>

    You should not proceed if the executable has not been found or there was any error running the process.
    
    You can look at git://anongit.kde.org/kde-workspace/solid/wicd/wirednetworkinterface.cpp, WicdWiredNetworkInterface::hardwareAddress to see how I implemented the "ifconfig" call. The important parts are the line
    
    qputenv("PATH", QString("/bin:/usr/bin:/sbin:/usr/sbin:" + env.value("PATH")).toAscii());
    
    This way you can easily add new paths to find.
    
    Use QProcess::waitForStarted() to check if the process was actually executed. If the executable was not found or the user does not has permission to run it waitForStarted will return error.



vpnplugins/vpnc/vpnc.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2921>

    Check the returned value for possible errors and act accordingly.



vpnplugins/vpnc/vpnc.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2922>

    same here.


- Lamarque Vieira


On May 23, 2011, 7:27 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101419/
> -----------------------------------------------------------
> 
> (Updated May 23, 2011, 7:27 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> First stab at VPN connection import/export functionality. Currently implemented just VPNC Import support. Please review, especially the VpncUiPluginPrivate part which tries to abstract away cisco password decrypt function. If the general approach looks good, I'll proceed with this and try to extend for other VPN methods, as well as export function.
> 
> 
> This addresses bug 146159.
>     http://bugs.kde.org/show_bug.cgi?id=146159
> 
> 
> Diffs
> -----
> 
>   libs/ui/vpnpreferences.cpp 843636c 
>   libs/ui/vpnuiplugin.h 7a13027 
>   settings/config/CMakeLists.txt 268c23b 
>   settings/config/addeditdeletebuttonset.h f7abef7 
>   settings/config/addeditdeletebuttonset.cpp 4f3f97a 
>   settings/config/manageconnectionwidget.h 51f60a0 
>   settings/config/manageconnectionwidget.cpp 46910db 
>   vpnplugins/novellvpn/novellvpn.h 9e026e2 
>   vpnplugins/novellvpn/novellvpn.cpp 848b527 
>   vpnplugins/openvpn/openvpn.h a06b88e 
>   vpnplugins/openvpn/openvpn.cpp 60376ed 
>   vpnplugins/pptp/pptp.h 66ea79a 
>   vpnplugins/pptp/pptp.cpp c311f9f 
>   vpnplugins/strongswan/strongswan.h fcd5bde 
>   vpnplugins/strongswan/strongswan.cpp 5bffc2b 
>   vpnplugins/vpnc/vpnc.h aec2136 
>   vpnplugins/vpnc/vpnc.cpp deb9108 
> 
> Diff: http://git.reviewboard.kde.org/r/101419/diff
> 
> 
> Testing
> -------
> 
> Tested against latest git snapshot, with KDE SC 4.6.3
> 
> 
> Thanks,
> 
> Rajeesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110523/ee309ae2/attachment-0001.htm