Review Request: [RFC] Import VPN connection

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101419/#review3454
-----------------------------------------------------------



libs/ui/vpnpreferences.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2901>

    This should be "> 5" since the array below is indexed to the 6th element ([5] is the 6th element, not the fifth).



libs/ui/vpnpreferences.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2902>

    same here.



vpnplugins/novellvpn/novellvpn.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2903>

    Is this method supposed to do something? If so then add a TODO comment about what it is going to do once implemented.



vpnplugins/novellvpn/novellvpn.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2900>

    Teh QVariantList is created cleared, this is redundant.



vpnplugins/openvpn/openvpn.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2904>

    redundant.



vpnplugins/pptp/pptp.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2905>

    redundant.



vpnplugins/strongswan/strongswan.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2906>

    redundant.



vpnplugins/vpnc/vpnc.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2907>

    Do not do this. If the readAll or the split calls return an unexpected result this will crash Plasma NM. Execute each call individually and test the result before using it.



vpnplugins/vpnc/vpnc.cpp
<http://git.reviewboard.kde.org/r/101419/#comment2908>

    This should be hardcoded unless you can garantee all Linux distributions, BSD*, Unix, etc store the exececutable in the same directory.


- Lamarque Vieira


On May 22, 2011, 4:30 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101419/
> -----------------------------------------------------------
> 
> (Updated May 22, 2011, 4:30 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> First stab at VPN connection import/export functionality. Currently implemented just VPNC Import support. Please review, especially the VpncUiPluginPrivate part which tries to abstract away cisco password decrypt function. If the general approach looks good, I'll proceed with this and try to extend for other VPN methods, as well as export function.
> 
> 
> This addresses bug 146159.
>     http://bugs.kde.org/show_bug.cgi?id=146159
> 
> 
> Diffs
> -----
> 
>   libs/ui/vpnpreferences.cpp 843636c 
>   libs/ui/vpnuiplugin.h 7a13027 
>   settings/config/CMakeLists.txt 268c23b 
>   settings/config/addeditdeletebuttonset.h f7abef7 
>   settings/config/addeditdeletebuttonset.cpp 4f3f97a 
>   settings/config/manageconnectionwidget.h 51f60a0 
>   settings/config/manageconnectionwidget.cpp 4c889c3 
>   vpnplugins/novellvpn/novellvpn.h 9e026e2 
>   vpnplugins/novellvpn/novellvpn.cpp 848b527 
>   vpnplugins/openvpn/openvpn.h a06b88e 
>   vpnplugins/openvpn/openvpn.cpp 60376ed 
>   vpnplugins/pptp/pptp.h 66ea79a 
>   vpnplugins/pptp/pptp.cpp c311f9f 
>   vpnplugins/strongswan/strongswan.h fcd5bde 
>   vpnplugins/strongswan/strongswan.cpp 5bffc2b 
>   vpnplugins/vpnc/vpnc.h aec2136 
>   vpnplugins/vpnc/vpnc.cpp deb9108 
> 
> Diff: http://git.reviewboard.kde.org/r/101419/diff
> 
> 
> Testing
> -------
> 
> Tested against latest git snapshot, with KDE SC 4.6.3
> 
> 
> Thanks,
> 
> Rajeesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110522/c8252afd/attachment-0001.htm