Review Request: secrets: do not save secrets if user asked for it

Andrey Borzenkov arvidjaar at gmail.com
Mon Mar 14 22:23:00 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100859/
-----------------------------------------------------------

Review request for Network Management.


Summary
-------

KNM now has three possible settings - Secure, PlainText and
DontStore. So != Secure is not equal PlainText. Ensure secrets
are not stored (as plain text!) if user asked for it.


Diffs
-----

  libs/internals/settings/gsmpersistence.cpp 1ddf3ca 
  libs/internals/settings/802-1xpersistence.cpp 740da06 
  libs/internals/settings/cdmapersistence.cpp 78a38b8 
  libs/internals/connectionpersistence.cpp df26574 
  libs/internals/kconfig_compiler.cpp fe75282 
  libs/internals/settings/802-11-wireless-securitypersistence.cpp ddfa78c 
  libs/internals/settings/pppoepersistence.cpp 44b9a34 
  libs/internals/settings/vpnpersistence.cpp 28e8af5 

Diff: http://git.reviewboard.kde.org/r/100859/diff


Testing
-------

Tested with current GIT master tip.


Thanks,

Andrey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110314/95660f77/attachment.htm 


More information about the kde-networkmanager mailing list