Review Request: vpnc: fix storing/loading of secrets type

Andrey Borzenkov arvidjaar at gmail.com
Mon Mar 14 19:30:38 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100857/
-----------------------------------------------------------

Review request for Network Management.


Summary
-------

secretsType is expected to have the same keys as secrets themselves.
vpnc was erroneously using old setting names for them, so secrets
were always saved even if user requested type "do not save" in config.

Group storage type was always ignored due to copy'n'paste error


Diffs
-----

  vpnplugins/vpnc/vpncauth.cpp eeeb00d 
  vpnplugins/vpnc/vpncwidget.cpp 71c828b 

Diff: http://git.reviewboard.kde.org/r/100857/diff


Testing
-------

Tested with current GIT master.


Thanks,

Andrey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110314/cc190d0c/attachment.htm 


More information about the kde-networkmanager mailing list