Review Request: internal: fix connecting to WiFi when "In file (unencrypted)" secrets storage is used

[Jirka Klimes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100855/
-----------------------------------------------------------

(Updated March 14, 2011, 4:06 p.m.)


Review request for Network Management.


Changes
-------

Updated patch to handle the issue in Security8021xSetting::hasSecrets() function rather than Connection:secretsAvailable()

This is probably a cleaner way. It works for my tests.


Summary
-------

When 'Connection Secrets' are configured to be stored as "In file (unencrypted)",
connecting to WiFi networks is not successful and stalls at "Waiting for authorization".

That is caused by not replying to GetSecrets() D-Bus call from NM. The problem is that
the WiFi connection contains Security8021xSetting even if it's not used (though it's
maked as not enabled). So we need to honour the enabled state of Security8021xSetting
in Connection::secretsAvailable().

The bug is filed in RH bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=682972


This addresses bug 243792.
    http://bugs.kde.org/show_bug.cgi?id=243792


Diffs (updated)
-----

  libs/internals/settings/802-1x.cpp 7387257 

Diff: http://git.reviewboard.kde.org/r/100855/diff


Testing
-------

I've successfully tested the patch on upstream mater branch.


Thanks,

Jirka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110314/eec6cec3/attachment.htm