Review Request: internal: fix connecting to WiFi when "In file (unencrypted)" secrets storage is used

[Andrey Borzenkov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100855/#review1935
-----------------------------------------------------------



libs/internals/connection.cpp
<http://git.reviewboard.kde.org/r/100855/#comment1627>

    Should not it rather apply this logic in hasSecrets() of Security8021xSetting? It really looks like layering violation in this case.


- Andrey


On March 14, 2011, 2:38 p.m., Jirka Klimes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100855/
> -----------------------------------------------------------
> 
> (Updated March 14, 2011, 2:38 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> When 'Connection Secrets' are configured to be stored as "In file (unencrypted)",
> connecting to WiFi networks is not successful and stalls at "Waiting for authorization".
> 
> That is caused by not replying to GetSecrets() D-Bus call from NM. The problem is that
> the WiFi connection contains Security8021xSetting even if it's not used (though it's
> maked as not enabled). So we need to honour the enabled state of Security8021xSetting
> in Connection::secretsAvailable().
> 
> The bug is filed in RH bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=682972
> 
> 
> This addresses bug RH:682972.
>     http://bugs.kde.org/show_bug.cgi?id=RH:682972
> 
> 
> Diffs
> -----
> 
>   libs/internals/connection.cpp 2914b39 
> 
> Diff: http://git.reviewboard.kde.org/r/100855/diff
> 
> 
> Testing
> -------
> 
> I've successfully tested the patch on upstream mater branch.
> 
> 
> Thanks,
> 
> Jirka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110314/f98d9990/attachment.htm