Review Request: Add an OpenConnect VPN plug-in

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101788/#review4211
-----------------------------------------------------------



vpnplugins/openconnect/openconnectauth.cpp
<http://git.reviewboard.kde.org/r/101788/#comment3454>

    Please add some comments explaining what do they mean. For instance, name is a hostname like DNS, right? Is address an IP address? What does group mean?



vpnplugins/openconnect/openconnectauth.cpp
<http://git.reviewboard.kde.org/r/101788/#comment3455>

    What kind of info does this return? I guess this comes from a header outside Plasma NM, if the header explains that you can just write a comment to look at the header file.
    
    This kind of comment is usefull for someone who take over Plasma NM maintainance in the future.



vpnplugins/openconnect/openconnectauth.cpp
<http://git.reviewboard.kde.org/r/101788/#comment3452>

    remove extra line.



vpnplugins/openconnect/openconnectauth.cpp
<http://git.reviewboard.kde.org/r/101788/#comment3456>

    Connect to what host? An openconnect web server? Is that server local or in the Internet? Please write a coment explaining those questions.



vpnplugins/openconnect/openconnectauth.cpp
<http://git.reviewboard.kde.org/r/101788/#comment3453>

    inherit from widget variable, you just need to delete widget and this will be deleted too. So this line is not needed. The same is true for infoText, icon, and verticalLayout.



vpnplugins/openconnect/openconnectauth.cpp
<http://git.reviewboard.kde.org/r/101788/#comment3457>

    Does this login to what? Please write a comment explaining that.


- Lamarque Vieira


On June 27, 2011, 7:05 p.m., Ilia Kats wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101788/
> -----------------------------------------------------------
> 
> (Updated June 27, 2011, 7:05 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> Add an OpenConnect VPN plug-in to KDE NM. First time using threads, so I don't know if that's how it's supposed to be done, but it seems to be working.
> Also, I can't figure out  how to make the loginForm QGroupBox have a minimum height, but get bigger when widgets get added. If the minimum height is 0, then both the box and the dialog get resized, however this causes visual "interference" as the serverLogBox jumps up and down as the upper loginForm box gets resized. Setting the minimum height of the loginForm box to 100 causes it to stay at 100 and squeeze the added widgets to fit the size, instead of getting bigger. Any ideas?
> 
> This requires OpenConnect >= 3.03 to build. 3.03 is not yet released, but the important thing is commit 423eee0b51a204562d6f2ec67893133ebcf200d6 from OpenConnect git (http://git.infradead.org/users/dwmw2/openconnect.git/ )
> 
> 
> This addresses bug 226028.
>     http://bugs.kde.org/show_bug.cgi?id=226028
> 
> 
> Diffs
> -----
> 
>   libs/internals/settings/vpnsecrets.cpp 0d9e3f9 
>   libs/ui/connectionsecretsjob.cpp d791bb3 
>   libs/ui/vpnuiplugin.h 444ab2a 
>   libs/ui/vpnuiplugin.cpp d058a52 
>   vpnplugins/CMakeLists.txt 4706a61 
>   vpnplugins/openconnect/CMakeLists.txt PRE-CREATION 
>   vpnplugins/openconnect/FindOpenConnect.cmake PRE-CREATION 
>   vpnplugins/openconnect/networkmanagement_openconnectui.desktop PRE-CREATION 
>   vpnplugins/openconnect/nm-openconnect-service.h PRE-CREATION 
>   vpnplugins/openconnect/openconnectauth.h PRE-CREATION 
>   vpnplugins/openconnect/openconnectauth.cpp PRE-CREATION 
>   vpnplugins/openconnect/openconnectauth.ui PRE-CREATION 
>   vpnplugins/openconnect/openconnectauthworkerthread.h PRE-CREATION 
>   vpnplugins/openconnect/openconnectauthworkerthread.cpp PRE-CREATION 
>   vpnplugins/openconnect/openconnectprop.ui PRE-CREATION 
>   vpnplugins/openconnect/openconnectui.h PRE-CREATION 
>   vpnplugins/openconnect/openconnectui.cpp PRE-CREATION 
>   vpnplugins/openconnect/openconnectwidget.h PRE-CREATION 
>   vpnplugins/openconnect/openconnectwidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101788/diff
> 
> 
> Testing
> -------
> 
> Yes, see the bugzilla ticket.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101788/s/191/
> 
> 
> Thanks,
> 
> Ilia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110627/cc5f4171/attachment-0001.htm