Review Request: Support for importing/exporting OpenVPN connections

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102059/#review5008
-----------------------------------------------------------



libs/ui/vpnuiplugin.h
<http://git.reviewboard.kde.org/r/102059/#comment4440>

    I have access to one OpenVPN connection. Your patch works, I could export my connection, import it again and it still connects.


- Lamarque Vieira


On July 23, 2011, 4:41 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102059/
> -----------------------------------------------------------
> 
> (Updated July 23, 2011, 4:41 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> Caveat emptor: There is one unresolved issue with isEncrypted() function - we need to check of key file is PKCS12 format or not. nm-applet achieves this through a call to nm_setting_802_1x_set_private_key(). I've googled a lot, and looks like there is no way to check PKCS12 file format in either Qt or KDE.
> If we are to add ad-hoc support via SEC_PKCS12DecoderStart and related functions from nss (which is what NetworkManager does), it wil introduce a new dependency on nss-devel.
> 
> 
> This addresses bug 194099.
>     http://bugs.kde.org/show_bug.cgi?id=194099
> 
> 
> Diffs
> -----
> 
>   libs/ui/vpnuiplugin.h 932d86f 
>   settings/config/manageconnectionwidget.cpp 780d50f 
>   vpnplugins/novellvpn/novellvpn.h a95926b 
>   vpnplugins/novellvpn/novellvpn.cpp 61d5519 
>   vpnplugins/openvpn/openvpn.h 4607cd5 
>   vpnplugins/openvpn/openvpn.cpp 6f126b8 
>   vpnplugins/pptp/pptp.h e513d3c 
>   vpnplugins/pptp/pptp.cpp e4efbd7 
>   vpnplugins/strongswan/strongswan.h d648217 
>   vpnplugins/strongswan/strongswan.cpp 9d4a8be 
>   vpnplugins/vpnc/vpnc.h 0b3f6db 
>   vpnplugins/vpnc/vpnc.cpp ea24cf1 
> 
> Diff: http://git.reviewboard.kde.org/r/102059/diff
> 
> 
> Testing
> -------
> 
> Only lightly tested, seems to import/export OK for sample configuration file. I don't have an OpenVPN connection, so it would be great if someone could test.
> 
> 
> Thanks,
> 
> Rajeesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110723/0c134af3/attachment.htm