Review Request: BSSID not recoginized

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100674/#review1478
-----------------------------------------------------------

Ship it!


Patch looks good, apart from some minor coding style issues. Please fix those and commit.

(I haven't tested it, but trust those that have =)


backends/NetworkManager/settingdbus.h
<http://git.reviewboard.kde.org/r/100674/#comment1254>

    (both lines) run & and argument together



backends/NetworkManager/settingdbus.cpp
<http://git.reviewboard.kde.org/r/100674/#comment1253>

    pull together & and nexMc 



backends/NetworkManager/settingdbus.cpp
<http://git.reviewboard.kde.org/r/100674/#comment1252>

    separate lines, parentheses



backends/NetworkManager/settingdbus.cpp
<http://git.reviewboard.kde.org/r/100674/#comment1251>

    no whitespace between & and binMac



backends/NetworkManager/settingdbus.cpp
<http://git.reviewboard.kde.org/r/100674/#comment1250>

    Separate lines and parentheses, please


- Sebastian


On Feb. 17, 2011, 3:24 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100674/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2011, 3:24 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> BSSID is provided in a bad format to NM daemon, which causes connection failures.  Also, MAC address is not sent correctly
> when you use "Restrict to Interface" combo. For WiFi that causes connection failure, for wired the setting is just
> ignored.
> 
> See also, https://bugs.kde.org/show_bug.cgi?id=238046
> 
> 
> Diffs
> -----
> 
>   backends/NetworkManager/settingdbus.h e0ef8ba 
>   backends/NetworkManager/settingdbus.cpp 20a4dc9 
>   backends/NetworkManager/settings/802-11-wirelessdbus.cpp 3ba8964 
>   backends/NetworkManager/settings/802-3-ethernetdbus.cpp 7d730c1 
>   libs/ui/802_11_wirelesswidget.cpp e671443 
> 
> Diff: http://git.reviewboard.kde.org/r/100674/diff
> 
> 
> Testing
> -------
> 
> Patch has been tested in the wild in fedora for awhile, a gentoo user in aforementioned bug reports success as well.
> 
> 
> Thanks,
> 
> Rex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110217/e88c2c83/attachment.htm