Review Request: [RFC] Make security widget validations work

[Rajeesh K Nambiar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102157/
-----------------------------------------------------------

(Updated Aug. 9, 2011, 1:04 p.m.)


Review request for Network Management.


Changes
-------

Simplified patch, thanks to Lamarque's review.
Also sets the validator in keyTypeChanged - this makes Passphrase to take any characters (tested with Unicode characters), thanks to Ilia.


Summary
-------

WEP key validation (should have only 5 to 13 ASCII characters for Ascii key; and 10 to 26 Hex characters for Hex key) wasn't working. Most of the bits were present, here's a gross hack to make it really work. Only implemented and tested WEP validation, but can be extended for other security types as well.

I'm not sure this could be the best/easiest implementation, spent a night figuring out the right signal/slots :-). If this hack could be refined, please let me know!


Diffs (updated)
-----

  libs/ui/security/securitywidget.h c536cf6 
  libs/ui/security/wepwidget.h e78338c 
  libs/ui/security/wepwidget.cpp f024555 
  libs/ui/security/wirelesssecuritysettingwidget.cpp fbc2c34 

Diff: http://git.reviewboard.kde.org/r/102157/diff


Testing
-------

Tested with WEP Hex and ASCII key validations. "OK" button of connection editor widget is now properly enabled/disabled upon changing key.


Thanks,

Rajeesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110809/8d969c16/attachment.html>