Review Request: [RFC] Make security widget validations work

[Rajeesh K Nambiar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102157/
-----------------------------------------------------------

(Updated Aug. 7, 2011, 4:05 p.m.)


Review request for Network Management.


Changes
-------

Thanks for the review.
Need to use signals (or Q_SIGNALS, which used) in the subclasses also to avoid linking error.


Summary
-------

WEP key validation (should have only 5 to 13 ASCII characters for Ascii key; and 10 to 26 Hex characters for Hex key) wasn't working. Most of the bits were present, here's a gross hack to make it really work. Only implemented and tested WEP validation, but can be extended for other security types as well.

I'm not sure this could be the best/easiest implementation, spent a night figuring out the right signal/slots :-). If this hack could be refined, please let me know!


Diffs (updated)
-----

  libs/ui/security/eapmethodstack.h 552f5c9 
  libs/ui/security/leapauthwidget.h 3c01e1d 
  libs/ui/security/nullsecuritywidget.h dc84fb5 
  libs/ui/security/securityleap.h 402a7af 
  libs/ui/security/securitywidget.h c536cf6 
  libs/ui/security/wepauthwidget.h 6ff721b 
  libs/ui/security/wepwidget.h e78338c 
  libs/ui/security/wepwidget.cpp f024555 
  libs/ui/security/wirelesssecuritysettingwidget.cpp fbc2c34 
  libs/ui/security/wpaauthwidget.h 91e7495 
  libs/ui/security/wpapskwidget.h 7077836 

Diff: http://git.reviewboard.kde.org/r/102157/diff


Testing
-------

Tested with WEP Hex and ASCII key validations. "OK" button of connection editor widget is now properly enabled/disabled upon changing key.


Thanks,

Rajeesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110807/790fe2a4/attachment.html>